8739805f99
2.3 KiB
type, id, title, status, date, supersedes, amends
| type | id | title | status | date | supersedes | amends |
|---|---|---|---|---|---|---|
| ADR | 0138 | Require Authenticode signing for all Windows release channels | active | 2026-06-09 | 0132 | 0130 |
Context
ADR 0132 temporarily allowed alpha Windows artifacts to build without Authenticode when the repository did not yet have Windows code-signing certificate secrets. That kept the alpha channel moving during certificate provisioning, but it also normalized unsigned Windows artifacts and made stable promotion exceptions easy to repeat.
At the same time, CI coverage uploads started failing because the pinned Codecov action still fetched Codecov's retired Keybase public-key account while the current Codecov CLI signatures use the original key from codecovsecops. That failure is unrelated to Windows Authenticode, but it blocked the same mainline quality lane and made release-readiness harder to reason about.
Decision
All Windows release artifacts must be Authenticode-signed before upload, for both alpha and stable channels.
- The reusable release artifact workflow no longer accepts a soft-gate input for Windows Authenticode.
- The Windows build validates that Tauri updater signing secrets and Windows Authenticode certificate/password secrets are present before packaging starts.
- The Windows build always passes the generated Authenticode config to
pnpm tauri build. - The Windows build always verifies the app executable and installer signatures with
Get-AuthenticodeSignaturebefore artifact upload. - Codecov uploads use the patched
codecov-actionrelease that imports Codecov's current public key source, preserving CLI integrity validation instead of skipping it.
Consequences
- Missing, expired, partial, or invalid Windows code-signing credentials fail alpha and stable release artifact builds.
- The repository cannot publish unsigned Windows installers as a convenience fallback.
- A trusted Windows code-signing certificate still has to come from a certificate authority or signing service; generating a local self-signed certificate is not an acceptable substitute for release artifacts.
- If Tolaria later adopts Microsoft Trusted Signing, Store packaging, or another signing provider, that integration should replace the PFX secret import path while preserving mandatory verification before upload.