8739805f99
Some checks failed
Auto-update PR branches / Update open PR branches (push) Has been cancelled
CI / Frontend Static Quality Checks (push) Has been cancelled
CI / Frontend Tests & Coverage (push) Has been cancelled
CI / Rust Tests & Quality Checks (push) Has been cancelled
CI / Linux build verification (push) Has been cancelled
Release (Alpha) / Compute alpha version (push) Has been cancelled
Release (Alpha) / Build release artifacts (push) Has been cancelled
Release (Alpha) / GitHub Release (alpha) (push) Has been cancelled
Release (Alpha) / Update docs and release pages (push) Has been cancelled
Deploy docs / Build VitePress site (push) Has been cancelled
Deploy docs / Deploy to GitHub Pages (push) Has been cancelled
1.9 KiB
1.9 KiB
type, id, title, status, date, supersedes, superseded_by
| type | id | title | status | date | supersedes | superseded_by |
|---|---|---|---|---|---|---|
| ADR | 0098 | In-app image and PDF previews for binary vault files | superseded | 2026-04-29 | 0086 | 0110 |
Context
ADR-0086 introduced the FilePreview path for image binaries while keeping binary files as ordinary VaultEntry records. The same file-first model should now cover PDFs, because asset-heavy vaults often mix screenshots, diagrams, and document exports that users need to inspect without leaving Tolaria.
Decision
Tolaria previews supported image and PDF files in the editor pane while keeping them as ordinary binary vault files.
- The scanner keeps the coarse
fileKind: "binary"representation. Previewability stays a renderer concern inferred from the file extension insrc/utils/filePreview.ts. - Supported images render with
<img>and supported PDFs render with the webview PDF object renderer, both using Tauri asset URLs fromconvertFileSrc. - The Tauri CSP permits scoped asset URLs in
object-srcso PDF objects can load vault-backed files without broadening script, connect, or image policy. - PDF preview fallback content lives inside the PDF object so unsupported or failed renderers still expose an explicit "Open in default app" escape hatch.
- Note-list rows for previewable images and PDFs remain clickable and carry file-specific indicators; unsupported binary rows stay muted and non-clickable.
Escapeon the preview surface returns keyboard focus to the note list, matching the existing image-preview keyboard behavior.
Consequences
- PDFs do not become notes and do not get Markdown editor semantics.
- The asset preview surface can keep growing to additional safe binary formats without changing the vault scanner or persisted cache shape.
- Broken PDFs may rely on the webview's own renderer failure state, but the surrounding Tolaria preview chrome still provides reveal, copy path, and default-app actions.